Skip to content

feat: Support VERSION file #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zccrs merged 3 commits into from
Jun 16, 2025
Merged

feat: Support VERSION file #288

zccrs merged 3 commits into from
Jun 16, 2025

Conversation

@asterwyx
Copy link
Contributor

@asterwyx asterwyx commented Jun 16, 2025

Use VERSION file to manage DTK version. VERSION file defines package
version. It also decides the initial value of cached variable
DTK_VERSION which controls the project version in cmake build system.
VERSION file is not synchronized to DTK6, as DTK6 has its own VERSION
file. One can still pass version to DTK_VERSION when running cmake
configure. This is helpful for developers.

Signed-off-by: Yixue Wang wangyixue@uniontech.com

deepin-ci-robot added a commit to linuxdeepin/qt6platform-plugins that referenced this pull request Jun 16, 2025
@deepin-ci-robot
sync: from linuxdeepin/qt5platform-plugins
12229d4 
Synchronize source files from linuxdeepin/qt5platform-plugins.

Source-pull-request: linuxdeepin/qt5platform-plugins#288
@deepin-ci-robot deepin-ci-robot mentioned this pull request Jun 16, 2025
Merged
@asterwyx asterwyx requested review from 18202781743 and zccrs June 16, 2025 07:30
asterwyx added 3 commits June 16, 2025 16:58
@asterwyx
feat: Support VERSION file
2b00042 
Use VERSION file to manage DTK version. VERSION file defines package
version. It also decides the initial value of cached variable
DTK_VERSION which controls the project version in cmake build system.
VERSION file is not synchronized to DTK6, as DTK6 has its own VERSION
file. One can still pass version to DTK_VERSION when running cmake
configure. This is helpful for developers.

Signed-off-by: Yixue Wang <wangyixue@uniontech.com>
@asterwyx
feat(ci): Add auto release workflow
be71ab3 
Signed-off-by: Yixue Wang <wangyixue@uniontech.com>
@asterwyx
chore: remove unused linglong.yaml
5cf0b02 
Linglong do not use this now.

Signed-off-by: Yixue Wang <wangyixue@uniontech.com>
deepin-ci-robot added a commit to linuxdeepin/qt6platform-plugins that referenced this pull request Jun 16, 2025
@deepin-ci-robot
sync: from linuxdeepin/qt5platform-plugins
0c68a80 
Synchronize source files from linuxdeepin/qt5platform-plugins.

Source-pull-request: linuxdeepin/qt5platform-plugins#288
@deepin-ci-robot
Copy link
Contributor

deepin-ci-robot commented Jun 16, 2025

deepin pr auto review

代码审查意见：

  1. 在.github/workflows/call-auto-release.yml文件中，workflow_dispatch和workflow_call的inputs部分重复了，可以提取成一个公共部分来减少代码重复。

  2. 在CMakeLists.txt文件中，读取VERSION文件并设置DTK_VERSION的方式是正确的，但是建议在读取文件时添加错误处理，以防文件不存在或读取失败。

  3. 在.reuse/dep5文件中，Files列表中新增了VERSION文件，但是没有对应的License和Copyright信息，需要补充完整。

  4. 在.syncexclude文件中，排除了VERSION文件，但是没有在.reuse/dep5文件中更新对应的Files列表，可能会导致版本信息无法正确同步。

  5. 在linglong.yaml文件被删除后，没有对应的更新或替换，可能会导致构建或部署过程中出现问题。

  6. 新增的VERSION文件和VERSION.in文件可能需要添加适当的注释或文档说明其用途和内容。

  7. 在CMakeLists.txt文件中，使用file(READ)读取文件内容并使用string(STRIP)去除首尾空白字符，这是一个好的做法，可以确保版本号的一致性。

  8. 整体来看，代码的改动主要集中在版本管理和自动化发布流程的改进，这些改动对于项目的版本控制和发布流程的自动化是有益的。但是，还需要确保这些改动不会对现有的构建和部署流程造成影响，并且需要测试新的版本管理和发布流程以确保其稳定性和可靠性。

@deepin-ci-robot
Copy link
Contributor

deepin-ci-robot commented Jun 16, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, asterwyx, zccrs

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zccrs zccrs merged commit 87ca335 into linuxdeepin:master Jun 16, 2025
18 of 20 checks passed
asterwyx pushed a commit to linuxdeepin/qt6platform-plugins that referenced this pull request Jun 18, 2025
@deepin-ci-robot @asterwyx
sync: from linuxdeepin/qt5platform-plugins
d0bcdac 
Synchronize source files from linuxdeepin/qt5platform-plugins.

Source-pull-request: linuxdeepin/qt5platform-plugins#288
asterwyx pushed a commit to linuxdeepin/qt6platform-plugins that referenced this pull request Jun 18, 2025
@deepin-ci-robot @asterwyx
sync: from linuxdeepin/qt5platform-plugins
e3f39eb 
Synchronize source files from linuxdeepin/qt5platform-plugins.

Source-pull-request: linuxdeepin/qt5platform-plugins#288
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zccrs zccrs zccrs approved these changes

@18202781743 18202781743 18202781743 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@asterwyx @deepin-ci-robot @zccrs @18202781743